Fixes #6693: fixes search functionality on iOS devices #6743
Conversation
…iate from isOpen props in Search component change setIsOpen to setIsMenuOpen in TopNav component
organize hook initializations in TopNav component: useState, useRef, useRouter
…h functionality on ios devices
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @MeetYourCreator! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
| @@ -110,7 +110,6 @@ export function Search({ | |||
| createPortal( | |||
| <DocSearchModal | |||
| {...options} | |||
| initialScrollY={window.scrollY} | |||
There was a problem hiding this comment.
Awesome stuff.
is this the actual fix? Can you explain what the problem was and how this fixes it?
There was a problem hiding this comment.
Hi @rickhanlonii 👋
Thanks so much! Yep, line 113 is the actual fix. I didn't take a look into the internals of the library, but it looks like the bug might actually be in the Autocomplete library. It looks like their DocSearchModal component has a bug in the modal design, which is causing the screen to freeze once the device width is less than about 755px.
width_at_755px_vs_741px.mp4
|
Thanks so much, @rickhanlonii 😀 |
Fixes search functionality on iOS devices
Fixes #6693
Current: Behavior of search functionality on iPhone 12 Pro
current-behavior_iPhone12pro.mp4
Fixes #6693: Behavior of search functionality on iPhone 12 Pro
behavior-with-fix_iPhone12pro.mp4