Skip to content

Revert inappropriate capitalization of "Transition" #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Apr 10, 2024

PR #6712 capitalized instances of "transition" to "Transition". I found one instance that shouldn't have been capitalized.

This tells React that the state Transition is not urgent, and it's better to keep showing the previous page instead of hiding any already revealed content. Now clicking the button "waits" for the `Biography` to load:

Here, "transition" in "state transition" does not refer to the React mechanism itself, so it should remain lowercase.

@rickhanlonii

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Apr 10, 2024 9:07am

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@rickhanlonii
Copy link
Member

Nice catch

@rickhanlonii rickhanlonii merged commit 342fddb into reactjs:main Apr 10, 2024
4 checks passed
@smikitky smikitky deleted the patch-3 branch April 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants