Sync with reactjs.org @ 2ef0ee1e #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was inconsistent across examples
* remove a reference to fbjs from codebase overview * Update codebase-overview.md Co-authored-by: Sunil Pai <[email protected]>
We shouldn't be encouraging this pattern which requires good understanding of JS quirks and can lead to bugs in other instances.
Added MyContext for clarity.
Removed unused props for clarity.
The ternary syntax using parenthesis was an unconventional prettier invention, going out of its way to format react ternaries differently from normal ternaries (if i remember correctly, because vim users had trouble re-formating without a mouse). If they made the right decision or not is one thing, but the additional noise could mislead beginners here, thinking they have to add more characters to make a simple 2-slot ternary, or that it is a "react thing".
Co-authored-by: Sunil Pai <[email protected]>
* Minor grammar edit (syntactic -> syntactical). * Update handling-events.md Co-authored-by: Sunil Pai <[email protected]>
* Clarify preferred "props default to true" expr The current text is ambiguous without reading further into the paragraph -- until I re-read this text, I was trying to avoid both types of syntax because it seemed to imply that it wans't recommended (eg "props default to true" --> "we don't recommend using this"). * Update jsx-in-depth.md Co-authored-by: Sunil Pai <[email protected]>
* Make React.memo documentation more clear * Update reference-react.md Co-authored-by: Sunil Pai <[email protected]>
* DOC: Updated the React Native Home URL * Blog: Updated the React URL Link * Relative link added
* Upgrade to node 12 LTS * Run prettier
Date change for Render-Atlanta 2020 due to the Coronavirus pandemic.
Having the information that the plugin is already installed by default after the installation instructions is probably wasting a lot of people's time. Moving it up probably avoids multiple installs of the plugin.
reactjs-translation-bot
requested review from
nstfkc,
helloanil and
suyalcinkaya
|
Deploy preview for tr-reactjs ready! Built with commit d9d4c3f |
alioguzhan
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 2ef0ee1
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.