Consolidate api and message files #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the old messages.py module by consolidating session-related functions into working_memory.py, updates API endpoints to call the consolidated implementations, and adjusts tests to use the new import paths and enums.
- Moved
list_sessions,get_session_memory,set_session_memory, anddelete_session_memoryfrommessages.pyintoworking_memory.pyand removedmessages.py. - Updated
api.pyto useworking_memory.list_sessionsandworking_memory.get_working_memoryfor session endpoints. - Revised tests to patch against
working_memoryand switched literal memory types toMemoryTypeEnum.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_messages.py | Removed obsolete tests for the old messages module |
| tests/test_long_term_memory.py | Updated patch target from messages.list_sessions to working_memory.list_sessions |
| tests/test_client_api.py | Updated patch target and replaced string memory_type with MemoryTypeEnum |
| tests/conftest.py | Switched MemoryMessage import from messages to models |
| agent_memory_server/working_memory.py | Added list_sessions() and updated get_working_memory() signature |
| agent_memory_server/messages.py | Deleted obsolete module |
| agent_memory_server/long_term_memory.py | Updated import to call working_memory.list_sessions |
| agent_memory_server/api.py | Removed old session endpoints and re-added them using working_memory |
Comments suppressed due to low confidence (2)
tests/test_messages.py:1
- The removal of
tests/test_messages.pyeliminates direct tests for session memory functions. Consider adding or relocating tests to coverworking_memory.list_sessionsandworking_memory.get_session_memoryto maintain coverage.
Entire file removed
agent_memory_server/working_memory.py:25
- [nitpick] The parameter name
redismay be ambiguous. Consider renaming it toredis_clientto match other usage in the codebase and clarify its purpose.
async def list_sessions(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some duplication after a larger refactor.