fix(store): honor limit parameter in Redis search operations (#30) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
approved these changes
Apr 30, 2025
The RedisStore and AsyncRedisStore search methods were hardcoded to return at most 10 results regardless of the specified limit parameter. This fix properly respects the user-specified limit when searching, enabling retrieval of more than 10 results when needed. - Modified _get_batch_search_queries to return limit and offset values - Updated search query creation to use Query.paging() method with the user-specified limit - Added integration tests to verify fix in both sync and async implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RedisStore and AsyncRedisStore search methods were hardcoded to return at most 10 results regardless of the specified limit parameter. This fix properly respects the
user-specified limit when searching, enabling retrieval of more than 10 results when needed.