fix: ensure version values are strings before Tag comparison (#40) #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #40 where numeric version values caused TypeError when compared with RedisVL Tag objects. The Tag type only accepts specific types (str, list, set, tuple, None) for comparison operations. The fix adds string conversion for all version values in the _dump_blobs method before they're used in Tag comparisons: - Added tests to reproduce and verify the issue - Added explicit string conversion using dict comprehension - Verified compatibility with existing functionality This prevents "TypeError: Right side argument passed to operator == with left side argument Tag must be of type..." errors when numeric versions are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #40 where numeric version values caused TypeError
when compared with RedisVL Tag objects. The Tag type only accepts
specific types (str, list, set, tuple, None) for comparison operations.
The fix adds string conversion for all version values in the _dump_blobs
method before they're used in Tag comparisons:
This prevents "TypeError: Right side argument passed to operator ==
with left side argument Tag must be of type..." errors when numeric
versions are used.