-
Notifications
You must be signed in to change notification settings - Fork 35
Upgrade to redisvl 0.4.0 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! a few minor things related to warnings and pinning ragas. but huge effort thank you!
python-recipes/RAG/01_redisvl.ipynb
Outdated
@@ -270,11 +268,19 @@ | |||
"outputId": "a8430acc-2e6d-45fd-fc8b-601fbbd8289b" | |||
}, | |||
"outputs": [ | |||
{ | |||
"name": "stderr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hate to do this but I think we should try to ignore these kinds of warnings if possible. Maybe a simple one liner will do it near top of notebook?
"name": "stderr", | ||
"output_type": "stream", | ||
"text": [ | ||
"huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set the env var here to suppress the warning
@@ -778,10 +835,10 @@ | |||
{ | |||
"data": { | |||
"text/plain": [ | |||
"\"Nike's revenue for the fiscal year ended May 31, 2023, was $51,217 million, while the revenue for the fiscal year ended May 31, 2022, was $46,710 million. This represents an increase in revenue from the previous year.\"" | |||
"\"Nike's revenue last year was $44,538 million, and this year it was $51,217 million.\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting it quotes some different numbers
"metadata": {}, | ||
"outputs": [], | ||
"outputs": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema error
} | ||
], | ||
"source": [ | ||
"%pip install -q redis \"unstructured[pdf]\" sentence-transformers langchain \"langchain-redis>=0.2.0\" langchain-huggingface langchain-openai ragas datasets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably best to pin ragas
given the issues we've had
No description provided.