Skip to content

[email protected] breaks support for < node 16, < node 14.18 #2391

Closed
@stellar-scottreed

Description

@stellar-scottreed

Description

Version v14.18 and v16 of node added support for the "node:" protocol for importing native node modules. This is made use of in this PR: #2373

This update breaks any application utilizing [email protected] on a node version prior to 16, 14.18. I think an update requiring an update to your node version should potentially be released as a major version and not minor?

Node.js Version

14.30

Redis Server Version

7.0.8

Node Redis Version

4.6.0

Platform

macOS

Logs

`% node test.js
internal/modules/cjs/loader.js:1032
  throw err;
  ^

Error: Cannot find module 'node:util'
Require stack:
- /Users//src/core/node_modules/@redis/client/dist/lib/cluster/cluster-slots.js
- /Users//src/core/node_modules/@redis/client/dist/lib/cluster/index.js
- /Users//src/core/node_modules/@redis/client/dist/index.js
- /Users//src/core/node_modules/redis/dist/index.js
- /Users//src/core/test.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1029:15)
    at Function.Module._load (internal/modules/cjs/loader.js:898:27)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)
    at Object.<anonymous> (/Users//src/core/node_modules/@redis/client/dist/lib/cluster/cluster-slots.js:17:21)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users//src/core/node_modules/@redis/client/dist/lib/cluster/cluster-slots.js',
    '/Users//src/core/node_modules/@redis/client/dist/lib/cluster/index.js',
    '/Users//src/core/node_modules/@redis/client/dist/index.js',
    '/Users//src/core/node_modules/redis/dist/index.js',
    '/Users//src/core/test.js'
  ]
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions