Fix cluster-slots discover race condition again #2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| const addressesInUse = new Set<string>(), | ||
| promises: Array<Promise<unknown>> = [], | ||
| eagerConnect = this.#options.minimizeConnections !== true; | ||
|
|
||
| for (const { from, to, master, replicas } of await this.#getShards(rootNode)) { | ||
| const shards = await this.#getShards(rootNode); | ||
| this.#resetSlots(); // Reset slots AFTER shards have been fetched to prevent a race condition |
There was a problem hiding this comment.
This regressed when b2d35c5 landed.
Is it possible to add a test to prevent further regressions?
There was a problem hiding this comment.
I dont see an easy way to test it..
I'll merge the PR as is for now, and we can add the test in another PR.. :)
|
Sorry about it.. I'm not sure what happened, but I'll need to make sure that we did not lose more work.. |
|
Hi we are really blocked by this for AWS Redis migration any luck that it get released? |
|
Hello, Does someone know when a new version including this fix will be released ? Many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This re-applies the fix done in #2731, as noted by @edwin-jones.
See #2704 for details.
Checklist
npm testpass with this change (including linting)?