Fix for multi operations with detect_buffers enabled

[jezell]

This fixes #263 where multi operations that properly should return arrays, return strings instead when detect_buffers: true.

[brycebaril]

Hi @jezell thank you for submitting! Think you could write up a couple tests in https://github.com/mranney/node_redis/blob/master/test.js to verify the patch works?

Thanks!

[jezell]

Sure thing

[ifraixedes]

+1

[jmonster]

just got bit by this -- 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍

[brycebaril]

@jmonster did you try the patch to see if it solved the problem? If so I will look into writing tests for this as @jezell hasn't been able to yet. Anyone else willing to write some tests for this would be very welcome :)

[ifraixedes]

@brycebaril, I wrote them, check the pull request #517.

[brycebaril]

Ahh, after spending some time reading the code I see an issue here -- it is incompatible with the hiredis (or other) parsers.

We'll need to look for a way to either do this enitrely in the parser, or entirely in the library. The parser tacking on data onto the Buffer and then using that data in the library creates a significant API change for parsers.

[jezell]

Setting the redisType value on the buffer was only needed to return integers as buffers. Looks like hiredis won't ever return a buffer unless the result is a string. Updated javascript parser so the behavior matches and removed the extra data from the buffer obj.

[BridgeAR]

This got fixed by #733. @jezell if I understand you correct the js parser is still not in line with hiredis? Would you be so kind and open another PR with fixing that issue and include a test for that?

[BridgeAR]

@jezell the parser part seems to still be needed. Would you mind rebasing?