Skip to content

fix: adding sentinelcommands to redis client #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2021
Merged

fix: adding sentinelcommands to redis client #1723

merged 1 commit into from
Nov 21, 2021

Conversation

sculley
Copy link
Contributor

@sculley sculley commented Nov 17, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • [ x ] Does $ tox pass with this change (including linting)?
  • [ x ] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [ x ] Is the new or changed code fully tested?
  • [ n/a ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

SentinalCommands have not been available to the Redis client since v3.5.3, this change re-adds the functionality to run SentinelCommands using the Redis client returned when setting up the Sentinel class.

closes #1714

@chayim chayim added the 4.0.+ label Nov 17, 2021
@chayim chayim self-requested a review November 18, 2021 07:11
@chayim chayim added 4.0.next bug Bug and removed 4.0.+ labels Nov 18, 2021
@chayim
Copy link
Contributor

chayim commented Nov 21, 2021

@sculley Hope you don't mind, I updated the description, in order to get the cross-close automation.

@chayim chayim merged commit d2b2333 into redis:master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Redis' object has no attribute 'sentinel_masters'
3 participants