Skip to content

fix broken link in hooks.md #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 6, 2019

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang commented Nov 14, 2019

Description

The mapstate link no longer points to the next version, but the matching version. As a result, it fixes #1453

@netlify
Copy link

netlify bot commented Nov 14, 2019

Deploy preview for react-redux-docs ready!

Built with commit 4ad6213

https://deploy-preview-1465--react-redux-docs.netlify.com

@thiskevinwang thiskevinwang force-pushed the kevin/Missing-page-#1453 branch from 43792e4 to ab30d03 Compare November 14, 2019 12:44
- remove extra whitespace
@thiskevinwang thiskevinwang marked this pull request as ready for review November 14, 2019 13:21
@timdorr
Copy link
Member

timdorr commented Nov 14, 2019

I don't think this is right. We should be linking to the appropriate markdown files and Docusaurus will convert them for us at build time.

@thiskevinwang
Copy link
Contributor Author

Ah I see. I'll take another stab at this Thanks @timdorr!

@thiskevinwang
Copy link
Contributor Author

@timdorr

For docs/api/hooks.md

I looked at docs/api/connect.md to check how a link was formatted, and it looks like 👇 (no .md)

  • (details [here](../using-react-redux/connect-mapstate#return-values-determine-if-your-component-re-renders))

For website/versioned_docs/version-7.1/api/hooks.md

Same observation as above.
Looked at website/versioned_docs//version-7.1/api/connect.md

I did take several stabs at trying point to a md file before coming back here, but no luck.

Any further thoughts?

@markerikson
Copy link
Contributor

Okay, that's why. Add a .md in that Markdown and it should fix things, I think.

@timdorr
Copy link
Member

timdorr commented Dec 6, 2019

Fixed it finally. Thanks!

@timdorr timdorr merged commit 5bef286 into reduxjs:master Dec 6, 2019
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
* fix broken link in hooks.md

* use relative path & redirected target

* update link in website/versioned
- remove extra whitespace

* Update hooks.md

* Update hooks.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing page
3 participants