Skip to content

fix(index): fix exports for UMD build (CDN script) #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

remarkablemark
Copy link
Owner

What is the motivation for this pull request?

fix(index): fix exports for UMD build (CDN script)

Fixes #828

What is the current behavior?

CDN (UMD) script throws error:

Uncaught ReferenceError: exports is not defined

What is the new behavior?

No error when loading by script

Checklist:

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #829 (6225395) into master (4885d1a) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##            master      #829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          172       172           
  Branches        58        58           
=========================================
  Hits           172       172           
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 10.32 KB (-0.22% 🔽) 207 ms (-0.22% 🔽) 33 ms (+97.52% 🔺) 240 ms

@remarkablemark remarkablemark merged commit 85e5a6b into master Feb 11, 2023
@remarkablemark remarkablemark deleted the fix/exports branch February 11, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError: exports is not defined
2 participants