Skip to content

Update to isbot@5 #11770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Update to isbot@5 #11770

merged 1 commit into from
Jul 3, 2024

Conversation

brophdawg11
Copy link
Contributor

No breaking changes from v4 - just removed a named export we don't use (pattern): https://github.com/omrilotan/isbot/blob/main/CHANGELOG.md#500

#11619 removed the v3/v4 version detection code so I also included that aspect in the changeset as a major version bump

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 7b63b61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@react-router/dev Major
react-router Major
react-router-dom Major
@react-router/express Major
@react-router/node Major
@react-router/serve Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Jul 3, 2024 that may be closed by this pull request
@brophdawg11 brophdawg11 mentioned this pull request Jul 3, 2024
@brookslybrand
Copy link
Contributor

Should we make this change in Remix as well or would that be considered a breaking change and why we're doing it here?

@brophdawg11
Copy link
Contributor Author

yeah dropping v3 would be breaking in Remix v2.

Going to v5 wouldn't be "breaking" per-se - but there's no reason we really need to. Remix handles v3/v4 currently and since v4 is API compatible with v5 it should handle v5 just fine and users can make that upate in their package.json without any changes on our end. See remix-run/remix#8841 (comment)

@brookslybrand
Copy link
Contributor

Sweet, I vaguely remembered a conversation about this, so thanks for pointing me to the discussion

@brophdawg11 brophdawg11 merged commit 3f25ab3 into v7 Jul 3, 2024
8 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/upgrade-isbot branch July 3, 2024 17:26
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to isbot@5
2 participants