refactor(react-router): replace substr with substring

[bilalk711]

Issue

In the history package, JS substr method was used that is deprecated now.

Solution

I replaced that method with substring and the functionality is not affected. It is just a minor refactor.

---

Supersedes #12077

[changeset-bot]

🦋 Changeset detected

Latest commit: cf98cde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
react-router	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/dev	Patch
react-router-dom	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch
@react-router/fs-routes	Patch
@react-router/remix-config-routes-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bilalk711]

@brophdawg11 can you please review and merge this PR?
It is just a minor refactor.

[brophdawg11]

@bilalk711 Could you clean up this PR so it's just your commits? I'm seeing a bunch of unrelated commits in here.

Could you also add a changeset per #12080 (comment)?

Included changes

[bilalk711]

@bilalk711 Could you clean up this PR so it's just your commits? I'm seeing a bunch of unrelated commits in here.

Could you also add a changeset per #12080 (comment)?

I removed the irrelevant commits and added a changeset.
I'm so sorry for that, I'll keep it in mind next time.

[brophdawg11]

Thanks!

[brophdawg11]

Just FYI this is going into dev so it ill be included in the v7 release when that comes out

[github-actions]

🤖 Hello there,

We just published version 7.0.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 6.28.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 6.28.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!