Skip to content

Fetch versions directly from npm registry url #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ErrorUtils.res
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
let getErrorMessage = exn =>
switch exn->Exn.message {
| Some(message) => message
| None => exn->String.make
}
61 changes: 61 additions & 0 deletions src/NpmRegistry.res
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
type response = {
ok: bool,
status: int,
json: unit => promise<Js.Json.t>,
}

@val external fetch: string => promise<response> = "fetch"

@scope(("process", "env"))
external npm_config_registry: option<string> = "NPM_CONFIG_REGISTRY"

@inline
let defaultRegistryUrl = "https://registry.npmjs.org"

let getNpmRegistry = () =>
npm_config_registry
->Option.flatMap(registry => registry->Node.Url.make)
->Option.mapOr(defaultRegistryUrl, url => url->Node.Url.href)

type fetchError =
| FetchError({message: string})
| HttpError({status: int})
| ParseError

let getFetchErrorMessage = fetchError => {
let message = switch fetchError {
| FetchError({message}) => `Fetch error. Message: ${message}`
| HttpError({status}) => `Http error. Status: ${status->Int.toString}`
| ParseError => "Parse error."
}

`Fetching versions from registry failed: ${message}`
}

let getPackageVersions = async (packageName, range) => {
let registryUrl = getNpmRegistry()

switch await fetch(`${registryUrl}/${packageName}`) {
| response if response.ok =>
switch await response.json() {
| Object(dict) =>
switch dict->Dict.get("versions") {
| Some(Object(dict)) =>
let versions =
dict
->Dict.keysToArray
->Array.filterMap(version =>
version->CompareVersions.satisfies(range) ? Some(version) : None
)
versions->Array.reverse
versions->Ok

| _ => Error(ParseError)
}
| _ => Error(ParseError)
}

| responseNotOk => Error(HttpError({status: responseNotOk.status}))
| exception Exn.Error(exn) => Error(FetchError({message: exn->ErrorUtils.getErrorMessage}))
}
}
8 changes: 8 additions & 0 deletions src/NpmRegistry.resi
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
type fetchError =
| FetchError({message: string})
| HttpError({status: int})
| ParseError

let getFetchErrorMessage: fetchError => string

let getPackageVersions: (string, string) => promise<result<array<string>, fetchError>>
45 changes: 19 additions & 26 deletions src/RescriptVersions.res
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,6 @@ let rescriptCoreVersionRange = ">=1.0.0"

type versions = {rescriptVersion: string, rescriptCoreVersion: string}

let getPackageVersions = async (packageName, range) => {
let {stdout} = await Node.Promisified.ChildProcess.exec(`npm view ${packageName} versions --json`)

let versions = switch JSON.parseExn(stdout) {
| Array(versions) =>
versions->Array.filterMap(json =>
switch json {
| String(version) if version->CompareVersions.satisfies(range) => Some(version)
| _ => None
}
)
| _ => []
}

versions->Array.reverse
versions
}

let getCompatibleRescriptCoreVersions = (~rescriptVersion, ~rescriptCoreVersions) =>
if CompareVersions.compareVersions(rescriptVersion, "11.1.0")->Ordering.isLess {
rescriptCoreVersions->Array.filter(coreVersion =>
Expand All @@ -32,25 +14,36 @@ let getCompatibleRescriptCoreVersions = (~rescriptVersion, ~rescriptCoreVersions
rescriptCoreVersions
}

let spinnerMessage = "Loading available versions..."

let promptVersions = async () => {
let s = P.spinner()

s->P.Spinner.start("Loading available versions...")
s->P.Spinner.start(spinnerMessage)

let (rescriptVersions, rescriptCoreVersions) = await Promise.all2((
getPackageVersions("rescript", rescriptVersionRange),
getPackageVersions("@rescript/core", rescriptCoreVersionRange),
let (rescriptVersionsResult, rescriptCoreVersionsResult) = await Promise.all2((
NpmRegistry.getPackageVersions("rescript", rescriptVersionRange),
NpmRegistry.getPackageVersions("@rescript/core", rescriptCoreVersionRange),
))

s->P.Spinner.stop("Versions loaded.")
switch (rescriptVersionsResult, rescriptCoreVersionsResult) {
| (Ok(_), Ok(_)) => s->P.Spinner.stop("Versions loaded.")
| _ => s->P.Spinner.stop(spinnerMessage)
}

let rescriptVersion = switch rescriptVersions {
| [version] => version
| _ =>
let rescriptVersion = switch rescriptVersionsResult {
| Ok([version]) => version
| Ok(rescriptVersions) =>
await P.select({
message: "ReScript version?",
options: rescriptVersions->Array.map(v => {P.value: v}),
})->P.resultOrRaise
| Error(error) => error->NpmRegistry.getFetchErrorMessage->Error.make->Error.raise
}

let rescriptCoreVersions = switch rescriptCoreVersionsResult {
| Ok(versions) => versions
| Error(error) => error->NpmRegistry.getFetchErrorMessage->Error.make->Error.raise
}

let rescriptCoreVersions = getCompatibleRescriptCoreVersions(
Expand Down
8 changes: 8 additions & 0 deletions src/bindings/Node.res
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ module Url = {
type t

@module("node:url") external fileURLToPath: t => string = "fileURLToPath"

@new external makeUnsafe: string => t = "URL"
@get external href: t => string = "href"

let make = string =>
try Some(makeUnsafe(string)) catch {
| Exn.Error(_exn) => None
}
}

module Os = {
Expand Down