Skip to content

Use execFile instead of exec to fix Windows path issue #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NewProject.res
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ let createNewProject = async () => {
await updateRescriptJson(~projectName, ~versions)

await RescriptVersions.installVersions(versions)
let _ = await Promisified.ChildProcess.exec("git init")
let _ = await Promisified.ChildProcess.execFile("git", ["init"])

s->P.Spinner.stop("Project created.")
}
3 changes: 1 addition & 2 deletions src/RescriptVersions.res
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,8 @@ let promptVersions = async () => {
let installVersions = async ({rescriptVersion, rescriptCoreVersion}) => {
let packageManager = PackageManagers.getActivePackageManager()
let packages = [`rescript@${rescriptVersion}`, `@rescript/core@${rescriptCoreVersion}`]
let command = `${packageManager} add ${packages->Array.join(" ")}`

let _ = await Node.Promisified.ChildProcess.exec(command)
let _ = await Node.Promisified.ChildProcess.execFile(packageManager, ["add", ...packages])
}

let esmModuleSystemName = ({rescriptVersion}) =>
Expand Down
2 changes: 1 addition & 1 deletion src/bindings/Node.res
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,6 @@ module Promisified = {
type execResult = {stdout: string, stderr: string}

@module("./NodePromisified.mjs")
external exec: string => promise<execResult> = "exec"
external execFile: (string, array<string>) => promise<execResult> = "execFile"
}
}
4 changes: 2 additions & 2 deletions src/bindings/NodePromisified.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { exec as execCallback } from "child_process";
import { execFile as execFileCallback } from "child_process";
import { promisify } from "util";

export const exec = promisify(execCallback);
export const execFile = promisify(execFileCallback);