Skip to content

Commit ed44142

Browse files
authored
Merge pull request #38 from stephanoskomnenos/fix-global-bindings
Fix incorrect bindings in `Global`
2 parents d9e174c + 6d1826a commit ed44142

File tree

3 files changed

+31
-2
lines changed

3 files changed

+31
-2
lines changed

src/Global.res

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,6 @@ let response = await fetch(myRequest)
505505
506506
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Window/fetch)
507507
*/
508-
@send
509508
external fetch_withRequest: (request, ~init: requestInit=?) => promise<response> = "fetch"
510509

511510
/**
@@ -567,7 +566,7 @@ Removes the event listener in target's event listener list with the same type, c
567566
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/EventTarget/removeEventListener)
568567
*/
569568
external removeEventListener: (
570-
string,
569+
eventType,
571570
eventListener<'event>,
572571
~options: eventListenerOptions=?,
573572
) => unit = "removeEventListener"

tests/Global__test.js

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/Global__test.res

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,18 @@ let response2 = await fetch(
1414
body: BodyInit.fromString(`secret=foo&response=bar`),
1515
},
1616
)
17+
18+
let response3 = await fetch_withRequest(
19+
Request.make2(~input="https://rescript-lang.org/"),
20+
~init={
21+
method: "POST",
22+
headers: HeadersInit.fromDict(
23+
dict{
24+
"Content-Type": "application/x-www-form-urlencoded",
25+
},
26+
),
27+
body: BodyInit.fromString(`secret=foo&response=bar`),
28+
},
29+
)
30+
31+
removeEventListener(Mousedown, MouseEvent.preventDefault, ~options={capture: false})

0 commit comments

Comments
 (0)