Skip to content

Fix incorrect bindings in Global #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2024
Merged

Fix incorrect bindings in Global #38

merged 2 commits into from
Dec 30, 2024

Conversation

stephanoskomnenos
Copy link
Contributor

#37

also params of removeEventListener

@nojaf
Copy link
Collaborator

nojaf commented Dec 30, 2024

Thanks, are you interested in adding a test for this specific API?
This could be useful for regression purposes if you plan on using this binding in your own projects. If there is no interest, we can merge this as is.

nojaf
nojaf approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, great PR! Many thanks!

@nojaf nojaf merged commit ed44142 into rescript-lang:main Dec 30, 2024
2 checks passed
@stephanoskomnenos stephanoskomnenos deleted the fix-global-bindings branch December 30, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanoskomnenos @nojaf