Skip to content

Remove Re module #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove Re module #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac34b1c
Remove `Re` module
aspeddro Jun 8, 2024
29fb848
update CHANGELOG.md
aspeddro Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Next version

- BREAKING: Remove `Re` module. Use the `RegExp` module. https://github.com/rescript-association/rescript-core/pull/231

## 1.4.0

- Add `RegExp.setLastIndex` function. https://github.com/rescript-association/rescript-core/pull/219
Expand Down
3 changes: 0 additions & 3 deletions src/RescriptCore.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ var MapperRt;

var Internal;

var Re;

var Exn;

var $$Option;
Expand Down Expand Up @@ -141,7 +139,6 @@ export {
$$Intl ,
MapperRt ,
Internal ,
Re ,
Exn ,
$$Option ,
List ,
Expand Down
1 change: 0 additions & 1 deletion src/RescriptCore.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ external import: 'a => promise<'a> = "#import"
type t<'a> = Js.t<'a>
module MapperRt = Js.MapperRt
module Internal = Js.Internal
module Re = Core__RegExp // needed for the %re sugar
module Exn = Js.Exn
module Option = Core__Option
module List = Core__List
Expand Down
Loading