Import attributes #811
Merged
Import attributes #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| 3. It should also have a `with` key, with another record where you put all the import attributes you want emitted. | ||
|
|
||
| Notice `\"some-exotic-identifier"` - you'll need to escape any key that's not a valid ReScript record key. | ||
| Also notice `type_`. Since `type` is a reserved keyword in ReScript, you can use `type_` instead. It will be output as `type` in the JavaScript code. |
There was a problem hiding this comment.
"you can use"
isn't it more like
"you need to use type_ instead"
since you cannot do it any other way?
There was a problem hiding this comment.
You can use type if you escape it, but since it's what you'll use 99% of the time I wanted it to have a "shortcut".
fhammerschmidt
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for rescript-lang/rescript#6599