Jsx adaptions #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyvetter
reviewed
Jan 15, 2021
| @@ -0,0 +1,30 @@ | |||
| @@warning("-27") | |||
There was a problem hiding this comment.
Where is this coming from? I don't think the ppx adds -27 so I'm surprised to see it.
There was a problem hiding this comment.
There was a problem hiding this comment.
I added the -27 attribute manually though
| @@ -25,16 +25,16 @@ external cloneElement: (element, 'props) => element = "cloneElement" | |||
| external createElementVariadic: (component<'props>, 'props, array<element>) => element = | |||
| "createElement" | |||
|
|
|||
| @module("react") @deprecated("Please use JSX syntax directly.") | |||
| @module("react/jsx-runtime") | |||
There was a problem hiding this comment.
I think we still want the @deprecated here. We want people to use JSX syntax or createElement. If we need to create a directly usable api we can do that outside of this work.
10 tasks
|
@ryyppy I guess this is obsolete and can be closed? |
|
@ryyppy @mattdamon108 Is there anything still relevant in this PR or can it be closed? |
|
I think JSX v4 has already a transformation using |
|
Ok, so I am closing this one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.