Prevent the "Start a build for this project to get the freshest data?" notification from spamming

[banacorn]

It pops up every time when a file is opened.
I don't even know what this notification means.

There should be an option for disabling this notification (in fact, every notification)
This is just annoying.

[banacorn]

It seems like the notification would appear only when the .bsb.lock is missing.

rescript-vscode/server/src/server.ts

Lines 144 to 147 in 9bbacb4

	// check if .bsb.lock is still there. If not, start a bsb -w ourselves
	// because otherwise the diagnostics info we'll display might be stale
	let bsbLockPath = path.join(projectRootPath, c.bsbLock);
	if (firstOpenFileOfProject && !fs.existsSync(bsbLockPath)) {

The notification becomes spammy if .bsb.lock is too short-lived.
Sometimes my .bsb.lock would keep getting deleted, but I don't know who did it.

[alex35mil]

IIRC .bsb.lock gets created/delete by compiler. As long as some bsb process is watching, .bsb.lock exists.

Sometimes my .bsb.lock would keep getting deleted, but I don't know who did it.

It might happen when you rebuild project often.

[chenglou]

It should only pop up for the first file of a project you open? Is that not the case for you? Got a video?

[banacorn]

Unfortunately I can't seem to reproduce it.

It happened after I converted everything from ReasonML to ReScript.
The problem only occurred in the first few hours, but I'm not sure what I did to stop it from spamming.

@Arafatamin, @thezjy, @mickeyvip, @BlueHotDog, @darenju, @kgtkr, @FilipKittnar.
Hey sorry for tagging you, could you share your experiences and observations about this problem?

[darenju]

Now that you mention it, I think I had the same problem than you: converting from ReasonML to ReScript.

I have not tried to make a new project using ReScript directly (partly because of the incomplete syntax highlighting), so I cannot say if the problem goes away after some time, or just after the first file was open.

[FilipKittnar]

It should only pop up for the first file of a project you open? Is that not the case for you? Got a video?

@chenglou , this happens very inconsistently but this morning it actually happened so I took a video. It can be seen how the .bsb.lock keeps appearing and disappearing when switching between .res files. But as I said, this happens inconsistently. Yesterday it was fine.
https://u.pcloud.link/publink/show?code=XZ9oY4XZA5FnABEd1qf7DraQFzJsbYaIlday

[banacorn]

I'm suspecting that this happens when there's only ONE .res file opened at a time.

[banacorn]

I'm suspecting that this happens when there's only ONE .res file opened at a time.

If that's the case, then I think it's a logical design rather then a bug.

But we still need to make it less annoying.
We need some sort of "debouncing" to make .bsb.lock live longer.
I'm wondering if it's possible to store "timestamp" in .bsb.lock (now it's just some number)

[FilipKittnar]

I'm not 100% sure about this but it seems to help to really wait a while (around 1 minute) after you click "Build" and before you switch to another file. After that it seems that the .bsb.lock file doesn't disappear.
Or of course you have the good old way of disregarding the plugin build and do your own bsb -make-world -clean-world -w .

[cristianoc]

There's some design discussion on an alternative workflow that does not depend on starting a watcher from within the editor. Still, it's speculative at the moment.

[em]

I'm using vercel with vercel dev and this already has fs watching built in that looks for changes in any file . If not for this nag, I think I could have a single development terminal and even include rescript in my yarn build script.

As I stands now I always need 2 terminals. One for rescript -w, and one for everything else through vercel dev / yarn build.

[b0o]

I agree that it would be nice to be able to turn this off entirely. I feel that it makes assumptions about the user's workflow that may not be correct. I personally prefer to run a separate build/watch process and I don't want to be reminded inside my editor.