Skip to content

Remove built-in e2e test templates #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Remove built-in e2e test templates #116

merged 1 commit into from
Apr 24, 2021

Conversation

chenglou
Copy link
Member

These never really worked due to some vscode issue; plus, we have our own tests in analysis/ already.

Though it's a good idea to explore these tests, so we should put them back one day. See the proper way to do it: https://github.com/microsoft/vscode-languageserver-node/blob/faa68d90a976f158a8403a0f5cce54117ce61dbb/client-node-tests/bin/runTests.js

These never really worked due to some vscode issue; plus, we have our own tests in analysis/ already.

Though it's a good idea to explore these tests, so we should put them back one day. See the proper way to do it: https://github.com/microsoft/vscode-languageserver-node/blob/faa68d90a976f158a8403a0f5cce54117ce61dbb/client-node-tests/bin/runTests.js
@chenglou chenglou merged commit a3b2c1d into master Apr 24, 2021
@chenglou chenglou deleted the rm-test branch April 24, 2021 07:59
@chenglou chenglou mentioned this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant