Skip to content

Forgot to reactivate windows CI test #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Apr 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
05242b0
Forgot to reactivate windows CI test
chenglou Apr 28, 2021
5745fe2
dos2unix test snapshots
chenglou Apr 28, 2021
31001b6
Try git newline
chenglou Apr 28, 2021
5824585
Cat Auto.res.txt
chenglou Apr 28, 2021
5e4d6af
Spit out charcodes
chenglou Apr 28, 2021
ff1c56f
Why didn't dos2unix on expected work?
chenglou Apr 28, 2021
998889d
Keep expected in windows newline
chenglou Apr 28, 2021
f142312
Show more precise diff
chenglou Apr 28, 2021
1d7057b
Try regular diff
chenglou Apr 28, 2021
5335604
Diff more clearly
chenglou Apr 28, 2021
922ab0a
Try cmp
chenglou Apr 28, 2021
bbd1acd
Hex dump
chenglou Apr 28, 2021
a222edb
Git diff earlier to debug
chenglou Apr 28, 2021
116a6cd
git diff even earlier
chenglou Apr 28, 2021
fbc9946
Cat everywhere
chenglou Apr 28, 2021
ba3ef0a
Last cats
chenglou Apr 28, 2021
4bfc215
Earliest git diff
chenglou Apr 28, 2021
3704f49
Git diff everywhere
chenglou Apr 28, 2021
7fbdb81
diff makefile. Cornered
chenglou Apr 29, 2021
5de2084
earliest in makefile
chenglou Apr 29, 2021
d21be91
Try without ocaml-env
chenglou Apr 29, 2021
b703366
Double check ocaml-env changing
chenglou Apr 29, 2021
b1c7e92
Add back ocaml-env
chenglou Apr 29, 2021
5a3aaf6
Try LF again
chenglou Apr 29, 2021
465796b
Use ocaml-env with LF
chenglou Apr 29, 2021
c0c0922
Put back most things
chenglou Apr 29, 2021
102557a
check windows bash newline behavior
chenglou Apr 29, 2021
699b72d
dos2unix in test script
chenglou Apr 29, 2021
e7a4127
Welp, dos2unix on the files get stuck...
chenglou Apr 29, 2021
1a10561
Throw more tests
chenglou Apr 29, 2021
6219eda
Sed away
chenglou Apr 29, 2021
66259f7
am i sedding wrong
chenglou Apr 29, 2021
e244658
Try sed again
chenglou Apr 29, 2021
faedf8a
Try all the crlf stripping
chenglou Apr 29, 2021
12718e8
perl works!
chenglou Apr 29, 2021
9a4e549
Clean up!
chenglou Apr 29, 2021
a1bab5a
Cause an intentional error
chenglou Apr 29, 2021
cfb72b5
Undo intentional bug
chenglou Apr 29, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,18 @@ jobs:
build: eval $(opam env) && cd analysis && make test
artifact-folder: linux
- os: windows-latest
build: |
cd analysis
# git checkout converted these to windows newline. Convert back to unix newline here
dos2unix test.sh tests/src/*.res tests/src/*.resi
& $env:CYGWIN_ROOT\\bin\\ocaml-env exec -- make
build: "cd analysis && & $env:CYGWIN_ROOT\\bin\\ocaml-env exec -- make test"
artifact-folder: win32

runs-on: ${{matrix.os}}

steps:
# needed for Windows testing
- name: Set git to use LF
run: |
git config --global core.autocrlf false
git config --global core.eol lf

- uses: actions/[email protected]

- name: Cache OCaml's opam
Expand Down
11 changes: 6 additions & 5 deletions analysis/test.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
function exp {
echo "$(dirname $1)/expected/$(basename $1).txt"
}

for file in tests/src/*.{res,resi}; do
./rescript-editor-analysis.exe test $file &> $(exp $file)
output="$(dirname $file)/expected/$(basename $file).txt"
./rescript-editor-analysis.exe test $file &> $output
# CI. We use LF, and the CI OCaml fork prints CRLF. Convert.
if [ "$RUNNER_OS" == "Windows" ]; then
perl -pi -e 's/\r\n/\n/g' -- $output
fi
done

warningYellow='\033[0;33m'
Expand Down