Skip to content

Fix possible infinite loop when bsconfig.json is not found. #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021
+3 −1
Merged

Fix possible infinite loop when bsconfig.json is not found. #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion analysis/src/Packages.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ let findRoot ~uri packagesByRoot =
if path = "/" then None
else if Hashtbl.mem packagesByRoot path then Some (`Root path)
else if Files.exists (path /+ "bsconfig.json") then Some (`Bs path)
else loop (Filename.dirname path)
else
let parent = Filename.dirname path in
if parent = path then (* reached root *) None else loop parent
in
loop (Filename.dirname path)

Expand Down