Skip to content

Refactor and clean up packages. #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 27, 2021
Merged

Refactor and clean up packages. #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9b78cb4
Refactor: clean up packages.
cristianoc May 26, 2021
d97846e
Consistent naming of project files.
cristianoc May 26, 2021
5f89c1b
interFileDependencies is actually never used.
cristianoc May 26, 2021
3ff7ac7
rename
cristianoc May 26, 2021
42b204f
No interface without implementation.
cristianoc May 27, 2021
c4f85cd
rename
cristianoc May 27, 2021
97f1c7f
Refactor findProjectFiles.
cristianoc May 27, 2021
6034f65
Rename compiledBase.
cristianoc May 27, 2021
cb8bdda
Convert example project.
cristianoc May 27, 2021
95dfa44
Delete .merlin
cristianoc May 27, 2021
e232b6d
Rename namespace in example project.
cristianoc May 27, 2021
03fcf7d
Refactor type paths.
cristianoc May 27, 2021
487f847
Split out a specific type for the module used to implement namespaces.
cristianoc May 27, 2021
7159f88
getCmt: make labelled argument interface non-optional.
cristianoc May 27, 2021
92ea8f2
Define getUri on paths, and make the returned value not optional.
cristianoc May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions analysis/.depend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ src/Protocol.cmx : src/vendor/Json.cmx
src/References.cmx : src/Utils.cmx src/Uri2.cmx src/SharedTypes.cmx \
src/ProcessCmt.cmx src/Log.cmx src/Infix.cmx
src/Shared.cmx : src/PrintType.cmx src/Log.cmx src/Files.cmx
src/SharedTypes.cmx : src/Utils.cmx src/Uri2.cmx src/Shared.cmx \
src/Infix.cmx
src/SharedTypes.cmx : src/Utils.cmx src/Uri2.cmx src/Shared.cmx
src/Uri2.cmx :
src/Utils.cmx : src/Protocol.cmx
src/vendor/Json.cmx :
Expand Down
2 changes: 2 additions & 0 deletions analysis/examples/example-project/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
lib
.merlin
2 changes: 1 addition & 1 deletion analysis/examples/example-project/bsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
},
"bs-dependencies": ["reason-react"],
"reason": { "react-jsx": 3 },
"namespace": "try-it",
"namespace": "my-namespace",
"refmt": 3
}
38 changes: 6 additions & 32 deletions analysis/examples/example-project/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions analysis/examples/example-project/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"dependencies": {
"bs-platform": "9.0.2",
"reason-react": "^0.9.1"
"reason-react": "^0.9.1",
"rescript": "^9.1.2"
},
"scripts": {
"build": "bsb -make-world",
"start": "bsb -make-world -w",
"clean": "bsb -clean"
"build": "rescript",
"start": "rescript build -w",
"clean": "rescript clean -with-deps"
}
}
188 changes: 0 additions & 188 deletions analysis/examples/example-project/src/Hello.re
View file
Open in desktop

This file was deleted.

Loading