Heuristic for JSX completion happening at the very end of a component with children #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Dec 19, 2023
cristianoc
reviewed
Dec 19, 2023
| @@ -45,3 +45,6 @@ module CompWithoutJsxPpx = { | |||
|
|
|||
| // <CompWithoutJsxPpx n | |||
| // ^com | |||
|
|
|||
| // <SomeComponent someProp=> | |||
There was a problem hiding this comment.
does this also work when there are children present?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment in the code says it all. Fixes an edge case where completing
<SomeComponent someProp=>after=wouldn't work because the parser doesn't parse this the same as<SomeComponent someProp= >(which does work because we get an expr hole insomeProp=).