fix extracted docs of types include escaped linebreaks in signature

[woeps]

Closes #888

Json.escape was called twice:

• once explicitly
• twice in Protocol.wrapInQuotes

I also updated the test, to not contain e.g. \\n

Since this is my first PR in this repo, I hope this is fine?

[aspeddro]

You can update tools/CHANGELOG.md?

[zth]

Awesome! I'm a bit worried about exotic identifiers if we don't escape. @woeps could you add a test case with a value like let \"SomeConstant\" = 12 and just make sure that the output doesn't break?

[woeps]

Awesome! I'm a bit worried about exotic identifiers if we don't escape. @woeps could you add a test case with a value like let \"SomeConstant\" = 12 and just make sure that the output doesn't break?

We still escape, because Protocol.wrapInQuotes calls Json.escape.
Before this PR, there were 4 places with someVar |> Json.escape |> Protocol.wrapInQuotes. This caused the strings being escaped twice.

Of cause, I'll add an additional test case and a note to the changelog.

[zth]

@woeps thanks for the explanation. This is ready to merge after that's settled. Could you test the other in progress PR too? I can release a new tools version after both of these are merged then.

[zth]

@woeps looks good, although there's a weird escape of : but maybe that doesn't matter. Ready to go?

[woeps]

@zth not sure which escape you mean?

Now (after updating changelog) it's good to go.