Fatal error with `bsb -make-world` in 7.2.1

[jwhitley]

Repro steps

1. git clone https://github.com/jwhitley/bsb-module-demo.git
2. cd bsb-module-demo
3. git checkout jwhitley/bsb-fatal-js-name-of-module-id
4. npm i
5. bsb -make-world

Expected result

Program builds

Actual result

Crash during build in step 5:

>>>> Start compiling
[3/3] Building src/demo.cmj
FAILED: src/demo.cmj src/demo.cmi /Users/whitley/src/3p/bsb-module-demo/lib/es6_global/src/demo.js
/Users/whitley/src/3p/bsb-module-demo/node_modules/bs-platform/darwin/bsc.exe -bs-package-name bsb-module-demo  -bs-package-output es6-global:lib/es6_global/src -color always -I src -warn-error +101  -o src/demo.cmj src/demo.reast
Fatal error: exception File "js_name_of_module_id.ml", line 35, characters 16-22: Assertion failed
FAILED: subcommand failed.
>>>> Finish compiling(exit: 1)

Bug notes

The only source file is src/demo.re, boiled down to one failing line which amounts to the use of Sys.argv[1]. As that file notes, removing the syntactic sugar to Array.get(Sys.argv, 1) doesn't change the error at all.

System notes

OS: macOS 10.15.3
Using OCaml:4.06.1+BS

[jwhitley]

Aside: when bs-platform is installed, it emits the OCaml version it's using. Is there a straightforward way to do this, e.g. via bsb? bsb -version doesn't emit the OCaml version.

[bobzhang]

Indeed, seems es6-global is broken, I will push a quick fix

Aside: when bs-platform is installed, it emits the OCaml version it's using. Is there a straightforward way to do this, e.g. via bsb? bsb -version doesn't emit the OCaml version.

bsc -version gives you the ocaml compiler version

[bobzhang]

fixed in #4223 will cherry pick it to 7.2

[bobzhang]

@jwhitley cherry picked to 7.2.2 and released

[jwhitley]

Confirmed fixed on my end in 7.2.2. Thanks!