bsconfig `“jsx”: 3`, but dependencies compiled v4

[mununki]

It seems compiling the dependencies with jsx v4, even though the project bsconfig is v3.
It starts compiling the dependencies with jsx v3, once the project bsconfig has “v3-dependencies” property.

[mununki]

can reproduce with https://github.com/mattdamon108/react-jsx-ppx-v4/tree/test-back-comp

[mununki]

Perhaps, dependencies that are not updated with v4 have only the old jsx config "reason.react-jsx" instead of the new jsx config?

let jsx, bsc_flags =
            match package_kind with
            | Pinned_dependency x | Dependency x ->
                if List.mem package_name x.jsx.v3_dependencies then
                  ( { jsx with version = Some Jsx_v3 },
                    "-open ReactV3" :: bsc_flags )
                else (x.jsx, bsc_flags) (* <-  here *)
            | _ -> (jsx, bsc_flags)
          in

EDIT: Not here. It works fine as intended.

[mununki]

Oh, I figure it out.
Actually propagating the global jsx config as v3, the user should explicitly add all dependencies with react component into "v3-dependencies"

Doesn't the compiler needs to add "-open ReactV3" automatically in case of global jsx config v3?

[cristianoc]

Oh, I figure it out. Actually propagating the global jsx config as v3, the user should explicitly add all dependencies with react component into "v3-dependencies"

Doesn't the compiler needs to add "-open ReactV3" automatically in case of global jsx config v3?

That would break compiling existing projects with existing (non-new) versions of rescript-react.

[mununki]

Yes, correct. I just see it in my local.
Don't we need to write down something like @rescript/react should not be put into "v3-dependencies"?

[cristianoc]

Yes, correct. I just see it in my local.
Don't we need to write down something like @rescript/react should not be put into "v3-dependencies"?

Perhaps yes a warning in the docs saying the new rescript-react is already compatible with V4.

[mununki]

I meant, it is not supposed to be there actually. If user put @rescript/react into "v3-dependencies", then user would see the cyclic dependencies error.

[cristianoc]

I meant, it is not supposed to be there actually. If user put @rescript/react into "v3-dependencies", then user would see the cyclic dependencies error.

Good point. Want to add the warning to the docs?

[mununki]

rescript-lang/syntax#659