BigInt comparison fails, Caml_obj_equal not working

[jmagaram]

Trying Core right now. This test fails.

  let num1 = BigInt.fromString("12345")
  let num2 = BigInt.fromString("9843")
  T.expect(num1 == num2)->T.Expect.toEqual(false)
  T.expect(num1 == num1)->T.Expect.toEqual(true)

Caml_obj.equal gives the wrong result. If I replace it with == or != it works.

[cristianoc]

Could you look at the generated code and see what's wrong? Presumably the compare function.

[cristianoc]

I asked a friend...

[cristianoc]

There's also a compare function which I guess has also not been adapted yet.

[jmagaram]

Here are the tests...

T.test("bigint equals", _ => {
  let x = BigInt.fromString("12345")
  let y = BigInt.fromString("9843")
  let areSame = x == x
  let areDiff = x != y
  T.expect(areDiff)->T.Expect.toEqual(true)
  T.expect(areSame)->T.Expect.toEqual(true)
})

This is the JavaScript...

Vitest.test("bigint equals", undefined, function (param) {
  var x = BigInt("12345");
  var y = BigInt("9843");
  var areSame = Caml_obj.equal(x, x);
  var areDiff = Caml_obj.notequal(x, y);
  Vitest$1.expect(areDiff).toEqual(true);
  Vitest$1.expect(areSame).toEqual(true);
});

I think it should get compiled to use == or != operators. This is Caml_obj_equal. Very weird code. If first param is a string or number or boolean it returns false, regardless of other???????? Also this code has no knowledge of "bigint" and maybe should.

function equal(a, b) {
  if (a === b) {
    return true;
  }
  var a_type = typeof a;
  if (a_type === "string" || a_type === "number" || a_type === "boolean" || a_type === "undefined" || a === null) {
    return false;
  }
  var b_type = typeof b;
  if (a_type === "function" || b_type === "function") {
    throw {
          RE_EXN_ID: "Invalid_argument",
          _1: "equal: functional value",
          Error: new Error()
        };
  }
  if (b_type === "number" || b_type === "undefined" || b === null) {
    return false;
  }
  var tag_a = a.TAG | 0;
  var tag_b = b.TAG | 0;
  if (tag_a === 248) {
    return a[1] === b[1];
  }
  if (tag_a === 251) {
    throw {
          RE_EXN_ID: "Invalid_argument",
          _1: "equal: abstract value",
          Error: new Error()
        };
  }
  if (tag_a !== tag_b) {
    return false;
  }
  var len_a = a.length | 0;
  var len_b = b.length | 0;
  if (len_a === len_b) {
    if (Array.isArray(a)) {
      var _i = 0;
      while(true) {
        var i = _i;
        if (i === len_a) {
          return true;
        }
        if (!equal(a[i], b[i])) {
          return false;
        }
        _i = i + 1 | 0;
        continue ;
      };
    } else if ((a instanceof Date && b instanceof Date)) {
      return !(a > b || a < b);
    } else {
      var result = {
        contents: true
      };
      var do_key_a = function (key) {
        if (!Object.prototype.hasOwnProperty.call(b, key)) {
          result.contents = false;
          return ;
        }
        
      };
      var do_key_b = function (key) {
        if (!Object.prototype.hasOwnProperty.call(a, key) || !equal(b[key], a[key])) {
          result.contents = false;
          return ;
        }
        
      };
      for_in(a, do_key_a);
      if (result.contents) {
        for_in(b, do_key_b);
      }
      return result.contents;
    }
  } else {
    return false;
  }
}

[jmagaram]

OMG on your friend. Not too bad.

[cristianoc]

[jmagaram]

Unbelievable.

[cristianoc]

@jmagaram I don't know if you're interested in providing a PR fix?
Otherwise, it's just a very quick change.

[jmagaram]

Thanks for the invite. I'll look into it. Probably easier if there was a codespace. I'll give it a try. Making progress...