Skip to content

Clean up tests in jscomp/test #6969

Closed
Closed
@cknitt

Description

@cknitt

As part of the effort to get rid of ninja.js for building the stdlibs and tests, the files in jscomp/test need to be cleaned up.

Note that due to ninja.js weirdness, there are currently some restrictions:

  1. Files in subdirectories are not compiled, only files directly in jscomp/test.
  2. File names must start with a lowercase letter, otherwise dependencies on such files are not handled correctly.

Tests are in the process of being converted from mocha (Mt.*) to the node test runner (Node_test.*/Node_assert.*).
Currently, mocha test files need to have the suffix _test and node test files need to have _ntest.

Proposed cleanup plan:

  1. Categorize test files and mark them with a prefix:
    • belt_: tests for the Belt namespace
    • js_: tests for the Js namespace
    • runtime_: tests for the compiler runtime (Curry etc.)
    • ocaml_: tests for the OCaml standard library
    • testutil_ (?): files containing only utility functions used by tests
    • output_: test files that do not call any actual test functions and are just here to be able to manually verify changes in the compiler output
  2. For files that do not contain any tests, remove the _test suffix.
  3. Finish converting tests from Mocha to the node test runner, with the exception of the tests for the OCaml standard library.
  4. When the OCaml standard library is removed from the compiler repo, also remove the corresponding tests.
  5. Once we have moved away from ninja.js to bsb or rewatch for building the stdlibs and tests, reorganize into subdirectories.

/cc @cometkim @fhammerschmidt

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions