@react.componentWithProps no longer works with @directive("'use memo'")

[nojaf]

Playground

type props = {count: int}

let someBoolean = v => Js.Math.random_int(1, v) % 2 == 0

@react.componentWithProps
let make =
  @directive("'use memo'")
  props => {
    if someBoolean(5) {
      React.useState(_ => 5)->ignore
    }
    Array.fromInitializer(~length=props.count, idx => idx)
    ->Array.map(_ =>
      <span className="text-2xl text-yellow-500 icon-[mdi-light--star]" />
    )
    ->React.array
  }

no longer transforms the function name of make.

[nojaf]

At first glance, the ppx is working as expected.

// A.res
  type props = {count: int}

  @react.componentWithProps
  let make = @directive("'use memo'")
      props => {
        Jsx.int(props.count)
      }

leads to

[
  structure_item 
    Pstr_type Nonrec
    [
      type_declaration "props"  
        ptype_params =
          []
        ptype_cstrs =
          []
        ptype_kind =
          Ptype_record
            [
              
                Immutable
                "count"                 core_type 
                  Ptyp_constr "int" 
                  []
            ]
        ptype_private = Public
        ptype_manifest =
          None
    ]
  structure_item 
    Pstr_value Nonrec
    [
      <def>
        pattern 
          Ppat_var "make" 
        expression 
          attribute  "directive"
            [
              structure_item 
                Pstr_eval
                expression 
                  Pexp_constant PConst_string ("'use memo'",Some "*j")
            ]
          Pexp_fun
          arity:1
          Nolabel
          None
          pattern 
            Ppat_var "props" 
          expression 
            attribute  "res.braces"
              []
            Pexp_apply
            expression 
              Pexp_ident "Jsx.int" 
            [
              <arg>
              Nolabel
                expression 
                  Pexp_field
                  expression 
                    Pexp_ident "props" 
                  "count" 
            ]
    ]
  structure_item 
    Pstr_value Nonrec
    [
      <def>
        pattern 
          Ppat_var "make" 
        expression 
          Pexp_let Nonrec
          [
            <def>
              pattern 
                Ppat_var "A" 
              expression 
                Pexp_fun
                arity:1
                Nolabel
                None
                pattern 
                  Ppat_var "props" 
                expression 
                  Pexp_apply
                  expression 
                    Pexp_ident "make" 
                  [
                    <arg>
                    Nolabel
                      expression 
                        Pexp_ident "props" 
                  ]
          ]
          expression 
            Pexp_ident "A" 
    ]
]

when running ./cli/bsc -dparsetree A.res -only-parse -bs-jsx 4.

The problem doesn't occur with other attributes than @directive.
@xyz for example will lead to function A as expected.

I would guess, it happens a bit later in the game.
@cristianoc any thoughts or pointers?

[cristianoc]

It does transform the name right?
In both cases it defines both make and Playground where they alias each other.

[cristianoc]

As to why make is emitted with the body, and not Playground, perhaps the jsx transform should add the attribute to Playground, not make.

[cristianoc]

The file js_pass_tailcall_inline.ml has checks directive = None; to disable inlining when a directive is present.
Removing those checks restores the correct naming of the function, though it removes the directive at the same time.