Skip to content

[refactoring] clean up arity which does not depend on type info anymore #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2016

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Jun 1, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.656% when pulling a9a9076 on ppx_global_config into 5aa9826 on master.

@bobzhang bobzhang merged commit 9e1714c into master Jun 1, 2016
@bobzhang bobzhang deleted the ppx_global_config branch June 1, 2016 18:04
@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.656% when pulling 9e704c5 on ppx_global_config into 5aa9826 on master.

kevinbarabash pushed a commit to kevinbarabash/rescript-compiler that referenced this pull request Dec 24, 2021
* Refactor parsing of string literals with a state machine

* Only log string escape sequence errors during scanning

* Remove unused string escape error messages in parsing.

Errors are reported during scanning, we don't need to report them both.
Ideally we should all do this in one pass…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants