Extend genType to recognise JSX V4 components.

[cristianoc]

No special treatment so far, just a normal function as if it were written by hand.

[cristianoc]

@mattdamon108 why does the type of props include key?
Normally one never calls the function directly passing key, but uses instead the same mechanism as for refs.

[mununki]

Unless the type props has the key, the type checking would not pass for the caller site.

<Comp key="key" />

[cristianoc]

JSX apply can treat key specially and simply add an explicit key:string type check.

[cristianoc]

Let me take a look at the spec and make a concrete suggestion.

[cristianoc]

Current:

<Comp x key="7">
// is converted to
React.createElement(Comp.make, {x, key: "7"})

New:

<Comp x key="7">
// is converted to
React.createElement(Comp.make, {x, key: ("7":string)})

[mununki]

Current:

<Comp x key="7">
// is converted to
React.createElement(Comp.make, {x, key: "7"})

New:

<Comp x key="7">
// is converted to
React.createElement(Comp.make, {x, key: ("7":string)})

Not sure I understand your intention.
Doesn't the New still needs the type props including key?

[cristianoc]

Current:

<Comp x key="7">
// is converted to
React.createElement(Comp.make, {x, key: "7"})

New:

<Comp x key="7">
// is converted to
React.createElement(Comp.make, {x, key: ("7":string)})

Not sure I understand your intention. Doesn't the New still needs the type props including key?

I think that's something one can work around.
But the lack of an empty record, one cannot work around I think #5623

So for now I'll filter it out on the genType side, even if it's a bit of magic that ideally I would prefer not to put in there.

[cristianoc]

Filtering out done here bfe431c

[mununki]

Side comment: I think you already know. The type props including key is needed, because the React.component has a type definition like this. https://github.com/rescript-lang/rescript-react/blob/master/src/React.res#L11:L19

[cristianoc]

Side comment: I think you already know. The type props including key is needed, because the React.component has a type definition like this. https://github.com/rescript-lang/rescript-react/blob/master/src/React.res#L11:L19

This is what I think one could work around, but the empty record, I don't think one can.