Skip to content

CI: replace deprecated set-output command with GITHUB_ENV #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2022
Merged

CI: replace deprecated set-output command with GITHUB_ENV #5734

merged 1 commit into from
Oct 15, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 15, 2022 •
edited
Loading

Got rid of all warnings coming from our scripts.
The few remaining ones are coming from Github's download artifact action and need to be fixed there.

@cknitt cknitt marked this pull request as ready for review October 15, 2022 07:57
@cknitt cknitt requested a review from cristianoc October 15, 2022 07:57
@cknitt cknitt linked an issue Oct 15, 2022 that may be closed by this pull request
CI: The set-output command is deprecated #5731
Closed
cristianoc
cristianoc approved these changes Oct 15, 2022
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the details, but looks good at the outside.

@cknitt cknitt merged commit a554d33 into rescript-lang:10.1_release Oct 15, 2022
@cknitt cknitt deleted the fix-ci-warning branch October 15, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: The set-output command is deprecated
2 participants
@cknitt @cristianoc