Skip to content

Revert to ubuntu 18.04 in CI #5871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Revert to ubuntu 18.04 in CI #5871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1afbe5d
Revert "Use the ubuntu-20.04 runner as 18.04 is deprecated (#5626)"
cknitt Dec 3, 2022
7a01dd6
Update CHANGELOG
cknitt Dec 3, 2022
3b774bf
Update comment
cknitt Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ jobs:
strategy:
fail-fast: false
matrix:
# Stay on the oldest Ubuntu version that's still supported by Github Actions
# to avoid glibc incompatibilities as far as possible.
os: [macos-latest, ubuntu-20.04, windows-latest, macos-arm]
# Use ubuntu-18.04 for glibc compatibility with older Linux distributions.
# Note that this will only be supported by Github until April 1st, 2023,
# see https://github.com/actions/runner-images/issues/6002.
os: [macos-latest, ubuntu-18.04, windows-latest, macos-arm]
ocaml_compiler: [4.14.0]

runs-on: ${{matrix.os}}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#### :bug: Bug Fix

- Prevent inlining of async functions in additional cases https://github.com/rescript-lang/rescript-compiler/issues/5860
- Revert to ubuntu-18.04 in CI to support Linux versions with older glibc https://github.com/rescript-lang/rescript-compiler/issues/5868

# 10.1.0

Expand Down