Skip to content

(v10.1) Support {} for empty inlined record literals and types #5901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 14, 2022
Merged

(v10.1) Support {} for empty inlined record literals and types #5901

merged 4 commits into from
Dec 14, 2022

Conversation

mununki
Copy link
Member

@mununki mununki commented Dec 12, 2022

Sync #5900 PR to 10.1_release

@mununki
Copy link
Member Author

mununki commented Dec 12, 2022

@cknitt CI seems different from that the master has. Do I miss something to make a PR goes to 10.1_release?

@cknitt
Copy link
Member

cknitt commented Dec 13, 2022

Yes, in 10.1_release snapshotting is still required (regenerate and check in whole_compiler.ml etc.).

@mununki
Copy link
Member Author

mununki commented Dec 13, 2022

@cknitt Ah! that means adding the snapshot will resolve the CI fails? I'll add it.

@mununki mununki merged commit 50aa83e into 10.1_release Dec 14, 2022
@mununki mununki deleted the fix-empty-inlined-record-2 branch December 14, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mununki @cknitt @cristianoc