Skip to content

Added as property to DOM props #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

Added as property to DOM props #5911

merged 1 commit into from
Dec 20, 2022

Conversation

cornedor
Copy link
Contributor

Changes from reasonml/reason-react#603

See https://html.spec.whatwg.org/multipage/links.html#link-type-preload for when this can be used. For example:

<link rel="preload" as="style" href="..." />

@cristianoc cristianoc requested a review from mununki December 16, 2022 16:54
mununki
mununki approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@mununki mununki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mununki
Copy link
Member

mununki commented Dec 17, 2022

@cknitt Would you advise if this change would go to 10.1_release or just to master?

@cknitt
Copy link
Member

cknitt commented Dec 17, 2022

I think it would be nice to have it on 10.1_release, too.

@mununki
Copy link
Member

mununki commented Dec 17, 2022

@cornedor Can you make another PR that goes to 10.1_release as a base branch?

@mununki
Copy link
Member

mununki commented Dec 17, 2022

FYI, master is a current trunk branch with the latest developing features. So backporting to 10.1_release is needed to be shipped in 10.1.*

@cornedor cornedor mentioned this pull request Dec 20, 2022
Merged
@mununki mununki merged commit f3c8562 into rescript-lang:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

@mununki mununki mununki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cornedor @mununki @cknitt