Skip to content

Add support for toplevel await. #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ subset of the arguments, and return a curried type with the remaining ones https
- Parser/Printer: unify uncurried functions of arity 0, and of arity 1 taking unit. There's now only arity 1 in the source language. https://github.com/rescript-lang/rescript-compiler/pull/5825
- Add support for default arguments in uncurried functions https://github.com/rescript-lang/rescript-compiler/pull/5835
- Inline uncurried application when it is safe https://github.com/rescript-lang/rescript-compiler/pull/5847
- Add support for toplevel `await` https://github.com/rescript-lang/rescript-compiler/pull/5940

#### :boom: Breaking Change

Expand Down
11 changes: 11 additions & 0 deletions jscomp/build_tests/super_errors/expected/await.res.expected
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

We've found a bug for you!
/.../fixtures/await.res:4:9-17

2 │ let foo = async () => {
3 │ let _ = ()
4 │ () => await a()
5 │ }
6 │

Await on expression not in an async context
5 changes: 5 additions & 0 deletions jscomp/build_tests/super_errors/fixtures/await.res
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
let a = async () => 3
let foo = async () => {
let _ = ()
() => await a()
}
2 changes: 1 addition & 1 deletion jscomp/frontend/bs_builtin_ppx.ml
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ let rec structure_mapper (self : mapper) (stru : Ast_structure.t) =
let mapper : mapper =
{
default_mapper with
expr = expr_mapper ~async_context:(ref false) ~in_function_def:(ref false);
expr = expr_mapper ~async_context:(ref true) ~in_function_def:(ref false);
pat = pat_mapper;
typ = typ_mapper;
signature_item = signature_item_mapper;
Expand Down
21 changes: 20 additions & 1 deletion jscomp/test/async_await.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';

var Caml_array = require("../../lib/js/caml_array.js");

function next(n) {
return n + 1 | 0;
Expand All @@ -18,7 +19,25 @@ function Make(I) {
};
}

async function topFoo(param) {
return 1;
}

var arr = [
1,
2,
3
];

var toplevelAwait = await topFoo(undefined);

var toplevelAwait2 = Caml_array.get(arr, await topFoo(undefined));

exports.next = next;
exports.useNext = useNext;
exports.Make = Make;
/* No side effect */
exports.topFoo = topFoo;
exports.arr = arr;
exports.toplevelAwait = toplevelAwait;
exports.toplevelAwait2 = toplevelAwait2;
/* toplevelAwait Not a pure module */
8 changes: 7 additions & 1 deletion jscomp/test/async_await.res
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,11 @@ module type Impl = {
}

module Make = (I: Impl) => {
let get = async key => await I.get(key)
let get = async (key) => await I.get(key)
}

let topFoo = async () => 1
let arr = [1, 2, 3]

let toplevelAwait = await topFoo()
let toplevelAwait2 = arr[await topFoo()]