Skip to content

better error message for extension point #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2023
Merged

better error message for extension point #5965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e7e179
better error message for extension point
aspeddro Jan 31, 2023
9104653
rename message for debugger extension
aspeddro Jan 31, 2023
5925db8
update CHANGELOG.md
aspeddro Jan 31, 2023
3519914
fix typo
aspeddro Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ These are only breaking changes for unformatted code.
- Process `@set` annotation for field update as generating an uncurried function https://github.com/rescript-lang/rescript-compiler/pull/5846
- Treat uncurried application of primitives like curried application, which produces better output https://github.com/rescript-lang/rescript-compiler/pull/5851
- New internal representation for uncurried functions using built-in type `function$<fun_type, arity>` this avoids having to declare all the possible arities ahead of time https://github.com/rescript-lang/rescript-compiler/pull/5870
- Better error message for extension point https://github.com/rescript-lang/rescript-compiler/pull/5965

# 10.1.1

Expand Down
10 changes: 7 additions & 3 deletions jscomp/frontend/ast_exp_handle_external.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,16 @@ let handle_debugger loc (payload : Ast_payload.t) =
Ast_external_mk.local_external_apply loc ~pval_prim:[ "#debugger" ]
~pval_type:(Typ.arrow Nolabel (Typ.any ()) (Ast_literal.type_unit ()))
[ Ast_literal.val_unit ~loc () ]
| _ -> Location.raise_errorf ~loc "bs.debugger does not accept payload"
| _ -> Location.raise_errorf ~loc "%%debugger extension doesn't accept arguments"

let handle_raw ~kind loc payload =
let is_function = ref false in
match Ast_payload.raw_as_string_exp_exn ~kind ~is_function payload with
| None -> Location.raise_errorf ~loc "bs.raw can only be applied to a string"
| None ->
(match kind with
| Raw_re -> Location.raise_errorf ~loc "%%re extension can only be applied to a string"
| Raw_exp -> Location.raise_errorf ~loc "%%raw extension can only be applied to a string"
| Raw_program -> Location.raise_errorf ~loc "%%%%raw extension can only be applied to a string")
| Some exp ->
{
exp with
Expand All @@ -99,4 +103,4 @@ let handle_raw_structure loc payload =
~pval_type:(Typ.arrow Nolabel (Typ.any ()) (Typ.any ()))
[ exp ];
}
| None -> Location.raise_errorf ~loc "bs.raw can only be applied to a string"
| None -> Location.raise_errorf ~loc "%%%%raw extension can only be applied to a string"