Fix issue with JSX V4 and newtype #6029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
added a commit
to rescript-lang/syntax
that referenced
this pull request
Mar 3, 2023
This is a port of PR rescript-lang/rescript#6029
cristianoc
added a commit
to rescript-lang/syntax
that referenced
this pull request
Mar 3, 2023
This is a port of PR rescript-lang/rescript#6029
Make the following changes: 1) Don't replace type variable `a` with `"type-a`", but leave it alone. 2) If the original `make` uses `(type a b, ...` wrap the first generated `make` with the same new type definitions 3) In the constraint `:props<'a, 'b>` where `'a` and `'b` were not constrained, use `:props<_, _>` instead. This avoids issues when e.g. `'a` is inferred to be a newtype bound in the make function, which would need to be mentioned explicitly and would give a type error. Fixes #5978 Replaces #6000
cristianoc
force-pushed
the
jsx_v4_newtype
branch
from
2866c10 to
5b010bb
Compare
cristianoc
added a commit
to rescript-lang/syntax
that referenced
this pull request
Mar 3, 2023
This is a port of PR rescript-lang/rescript#6029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the following changes:
awith"type-a", but leave it alone.makeuses(type a b, ...wrap the first generatedmakewith the same new type definitions:props<'a, 'b>where'aand'bwere not constrained, use:props<_, _>instead. This avoids issues when e.g.'ais inferred to be a newtype bound in the make function, which would need to be mentioned explicitly and would give a type error.Fixes #5978 Replaces #6000