Skip to content

Downgrade setup-ocaml to fix Windows CI issue #6034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Mar 5, 2023

setup-ocaml 2.0.11 contains the following change:

Don't install Cygwin's git or mercurial packages (reduces cache by ~90MB).

(see also ocaml/setup-ocaml#648)

In our CI script, we are setting up the git config as follows for Windows:

git config --global core.autocrlf false
git config --global core.eol lf

With the Git Windows client (already installed in the runner image) used instead of Cygwin's git, this causes the following error when running git diff later on in the CI process:

Run git diff --exit-code lib/js lib/es6
fatal: bad boolean config value 'false
' for 'core.autocrlf'

I am therefore pinning the setup-ocaml version to 2.0.10 for now.

@cknitt cknitt changed the title Try to fix Windows CI build Downgrade setup-ocaml to fix Windows CI issue Mar 5, 2023
@cknitt cknitt marked this pull request as ready for review March 5, 2023 18:53
@cknitt cknitt requested a review from cristianoc March 5, 2023 18:53
@cknitt cknitt merged commit e9b20ae into rescript-lang:master Mar 5, 2023
@cknitt cknitt deleted the fix-windows-ci branch March 5, 2023 19:05
cknitt added a commit to cknitt/rescript that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants