Improve code generated for default arguments in JSX V4 #6041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
added a commit
to rescript-lang/syntax
that referenced
this pull request
Mar 6, 2023
cristianoc
added a commit
to rescript-lang/syntax
that referenced
this pull request
Mar 6, 2023
cristianoc
force-pushed
the
optional_args_better_code
branch
from
44a54bd to
931fa0b
Compare
cristianoc
added a commit
to rescript-lang/syntax
that referenced
this pull request
Mar 6, 2023
cristianoc
added a commit
to rescript-lang/syntax
that referenced
this pull request
Mar 6, 2023
This
```res
@react.component
let foo = (~x, ~y=3+x, ?z) => ...
```
was generating
```res
({props: props<_, _, _>) => {
let x = props.x
let y = switch props.y {
| None => 3 + x
| Some(y) => y
}
let z = props.z
...
```
now it generates instead
```
({x, ?y, ?z}: props<_, _, _>) => {
let x = x
let y = switch y {
| None => 3 + x
| Some(y) => y
}
let z = z
...
```
the different in generated code is that bindings such as `let x = props.x` are not present in the `js` output.
Functions of the form `(~comp as module(Comp: Comp))=>` are represented internally as a `Pexp_constraint`, which makes them look like `~comp : t`. Now special-case this pattern so it's treated just like the other forms of `as ...`. Fixes #5976
cristianoc
force-pushed
the
optional_args_better_code
branch
from
32ad5cb to
61ae789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
was generating
({props: props<_, _, _>) => { let x = props.x let y = switch props.y { | None => 3 + x | Some(y) => y } let z = props.z ...now it generates instead
({x, ?y, ?z}: props<_, _, _>) => { let x = x let y = switch y { | None => 3 + x | Some(y) => y } let z = z ...the different in generated code is that bindings such as
let x = props.xare not present in thejsoutput.