Skip to content

Make "rescript format" work with node 10 again and set "engines" field #6186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@

- Parse `assert` as a regular function. `assert` is no longer a unary expression. Example: before `assert 1 == 2` is parsed as `(assert 1) == 2`, now it is parsed as `assert(1 == 2)`. https://github.com/rescript-lang/rescript-compiler/pull/6180

#### :bug: Bug Fix

- Make "rescript format" work with node 10 again and set minimum required node version to 10 in package.json. https://github.com/rescript-lang/rescript-compiler/pull/6186

# 11.0.0-alpha.4

#### :rocket: Main New Feature
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"prettier": "^2.7.1",
"rollup": "^0.49.2"
},
"engines": {
"node": ">=10"
},
"bin": {
"bsc": "bsc",
"bstracing": "lib/bstracing",
Expand Down
2 changes: 1 addition & 1 deletion scripts/rescript_format.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var format_usage = `Usage: rescript format <options> [files]
\`rescript format\` formats the current directory
`;
var child_process = require("child_process");
var util = require("node:util");
var util = require("util");
var asyncExecFile = util.promisify(child_process.execFile);
var path = require("path");
var fs = require("fs");
Expand Down