Skip to content

Convert most of jscomp/others to .res #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jun 1, 2023

This converts the modules in jscomp/others to .res syntax, with the following exceptions:

  • js.ml
  • js_dict.ml(i)
  • js_math.ml
  • js_string.ml
  • node.ml

The reason is that if I convert any of these, I get unwanted/unexpected changes in the release.ninja.
We can handle them in a later PR.

@cknitt cknitt force-pushed the others branch 6 times, most recently from d49d07b to 0fb8fe8 Compare June 2, 2023 11:32
@cknitt cknitt changed the title WIP: Fully convert jscomp/others to .res Convert most of jscomp/others to .res Jun 3, 2023
@cknitt cknitt marked this pull request as ready for review June 3, 2023 13:17
@cknitt cknitt requested review from cristianoc and ryyppy June 3, 2023 13:17
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@cknitt cknitt merged commit cca9840 into rescript-lang:master Jun 3, 2023
@cknitt cknitt deleted the others branch June 3, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants