Skip to content

fix: incorrect comment on Math.sign #7188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: incorrect comment on Math.sign #7188

merged 1 commit into from
Dec 3, 2024

Conversation

JUSTIVE
Copy link
Contributor

@JUSTIVE JUSTIVE commented Dec 3, 2024

Math.sign(negative_value) should be -1.0 instead of 1.0

@JUSTIVE
fix: incorrect comment on Math.sign
2cd9725 
Math.sign(negative_value) should be -1.0 instead of 1.0
@fhammerschmidt fhammerschmidt enabled auto-merge (squash) December 3, 2024 19:27
@fhammerschmidt
Copy link
Member

Thanks!

@fhammerschmidt fhammerschmidt merged commit c56ad6f into rescript-lang:master Dec 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JUSTIVE @fhammerschmidt