Skip to content

ci: remove bash hack on Windows #7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ jobs:
key: ${{ env.opam_cache_key }}

- name: Use OCaml ${{matrix.ocaml_compiler}}
uses: ocaml/setup-ocaml@v3.1.4
uses: ocaml/setup-ocaml@v3.2.2
if: steps.cache-opam-env.outputs.cache-hit != 'true'
with:
ocaml-compiler: ${{matrix.ocaml_compiler}}
Expand Down Expand Up @@ -244,11 +244,6 @@ jobs:
fi
shell: bash

# see https://github.com/ocaml/setup-ocaml/issues/815
- name: "Windows: set SHELLOPTS=igncr"
if: runner.os == 'Windows'
run: echo "SHELLOPTS=igncr" >>"$GITHUB_ENV"

- name: Build compiler
if: runner.os != 'Linux'
run: opam exec -- dune build --display quiet --profile release
Expand Down Expand Up @@ -338,7 +333,7 @@ jobs:
with:
path: ./tests/benchmark-cache
key: syntax-benchmark-v1

- name: Create new benchmark data and comment on alert
# Do not run for PRs created from other repos as those won't be able to write to the pull request
if: ${{ matrix.benchmarks && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.repository.full_name) }}
Expand All @@ -359,7 +354,7 @@ jobs:
with:
path: ./tests/benchmark-cache
key: syntax-benchmark-v1

- name: Build playground compiler
if: matrix.build_playground
run: |
Expand Down Expand Up @@ -396,7 +391,7 @@ jobs:
needs:
- build-compiler
- build-rewatch

runs-on: ubuntu-latest

steps:
Expand Down
Loading