fix && || tail call, it generates some large expressions (Fix #50) #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike `return +(code>31 && code< 96)`, we can improve it later
| @@ -149,7 +149,12 @@ function caml_string_of_char_array(chars) { | |||
|
|
|||
| function caml_is_printable(c) { | |||
| var code = c; | |||
| return +(code > 31 && code < 127); | |||
| if (code > 31) { | |||
bobzhang
added a commit
that referenced
this pull request
Feb 4, 2016
fix && || tail call, it generates some large expressions (Fix #50)
Mathspy
pushed a commit
to Mathspy/melange
that referenced
this pull request
Mar 28, 2021
kevinbarabash
pushed a commit
to kevinbarabash/rescript-compiler
that referenced
this pull request
Dec 24, 2021
* Implement outcome printing of polymorphic variants * Omit printing of leading Ptyp_variant bar when layout doesn't break. type color = [ #Red | #Blue | #Green ] VS type color = [ | #Red | #Blue | #Green ] Should be consistent with outcome printer * Improve consistency spacing brackets surrounding poly vars in outcome printer [ #red ] should be [#red] * Improve consistency spacing brackets surrounding poly vars in typexpr printer [ #red ] should be [#red] * Print exotic names escaped in poly-var outcome printer * Document meaning of outcome printer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for things like
return +(code>31 && code< 96), we can improve it later